Remove no-op line #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed line is imho unnecessary and can be removed for two reasons: 1) Float32Array.set takes an array and an optional numeric However, in the removed line, these parameters were passed in switched order, resulting in a no-op (afaict) 2) It seems that the idea was to zero the elements in the array because the last chunk is smaller than the array size. However, the array is already created with its values set to 0.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed line is imho unnecessary and can be removed for two reasons:
Float32Array.set takes an array and an optional numeric
However, in the removed line, these parameters were passed
in switched order, resulting in a no-op (afaict)
It seems that the idea was to zero the elements in the
array because the last chunk is smaller than the array size.
However, the array is already created with its values set
to 0.