dynamic Article page created #28
Conversation
|
Added Assets template to load static banner in templates, static folder is not the correct way to do it |
| import ArticleThumbnail from '../components/ArticleThumbnail'; | ||
| import FeaturedArticle from '../components/FeaturedArticle'; | ||
| import NewsCarousel from '../components/NewsCarousel'; | ||
| const marked = require("marked"); |
There was a problem hiding this comment.
Let's maintain a consistent import statement.
import marked from 'marked'
| @@ -1,6 +1,7 @@ | |||
| import React, { Component } from 'react'; | |||
| import { Link } from 'gatsby'; | |||
| import AccountDropdown from './AccountDropdown'; | |||
| import logo from '../assets/banner.png'; | |||
There was a problem hiding this comment.
Might introduce some merge conflicts with currently in-development features, but it's the correct way of handling it
| @@ -25,5 +25,13 @@ html { | |||
| @apply flex-grow | |||
| } | |||
|
|
|||
| .article-content { | |||
There was a problem hiding this comment.
We need a consistent way of handling stylesheets, there are currently two separate ones for no specific reasons. I would say that we can either build a proper component stylesheet that is reused consistently across the page, or we continue with inline styling like most of the components have so far. This might interest also @Bruck1701.
Let me know what you guys think!
There was a problem hiding this comment.
Totally agree that we should try to keep everything as consistent as possible!
Even though I used inline styling, I think it would be better to have a component stylesheet.
Inline styling can make it harder to change the code uniformly later, right?
| @@ -1,14 +1,15 @@ | |||
| import React from 'react'; | |||
| import { Link } from 'gatsby'; | |||
| import { FaTwitter, FaDiscord, FaGithub, FaLinkedin } from 'react-icons/fa'; | |||
| import logo from '../assets/banner.png'; | |||
|
|
|||
There was a problem hiding this comment.
See Header's comment.
| }) | ||
| }) | ||
| // highlight-end | ||
| } |
There was a problem hiding this comment.
Damn, I absolutely hate when APIs mix requires and imports.
|
I just realized you have been developing this from the |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #8
What is the new behavior?
Added dynamic article page that load mocked data from gatsby-node.js
-
Does this introduce a breaking change?
Other information