-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hubs compatible with Z2JH 1.0.0 #414
Comments
With hhttps://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/2200, helm will default to not allowing arbitrary extra properties anywher except under jupyterhub.custom. This helps us move towards 1.0 Ref 2i2c-org#414
As usual, a very thorough and thought out issue, @consideRatio. THANK YOU. I've verified that all our current clusters are on at least 1.19. Opened #412 to decide ongoing policy. Our GitHub actions use https://github.com/Azure/setup-helm, which uses latest stable version of helm. So that's 3.5. I opened #415 for custom.cloudResources. I've some more thinking to do for singleuser.admin. We use a single pre-configured PVC (https://github.com/2i2c-org/pilot-hubs/blob/master/hub-templates/basehub/templates/nfs-pvc.yaml) for all users, and don't use dynamic provisioning at all. So deleting of PVCs doesn't affect us. https://pilot-hubs.2i2c.org/en/latest/topic/storage-layer.html has more info about our home directory storage. |
@yuvipanda I scanned the cluster specific configs and found |
Ref 2i2c-org#414 In preparation for strict schema validation of helm config from jupyterhub/zero-to-jupyterhub-k8s#2200
#417 just moved home page stuff under custom, I think that's good enough for now. |
We should just move it under custom for now I think |
Background
Z2JH 1.0.0 introduce breaking changes, we must make some adjustments.
Expected timeline
End of May.
Steps to complete this goal
basehub
and its default values (-> relocate singleuser.admin / cloudResources)daskhub
and its default values (-> relocate singleuser.admin / cloudResources)cloudResources
tocustom.cloudResources
(?) where Z2JH 1.0.0 won't complain about a passed value it doesn't recognize.singleuser.admin
tocustom.singleuserAdmin
(?) where Z2JH 1.0.0 won't complain about a passed value it doesn't recognize.homepage
tocustom.homepage
or perhapsglobal.2i2c.homepage
where Z2JH 1.0.0 won't complain about a passed value it doesn't recognize. Note thatglobal
variables are not made accessible fromget_config
though, but such feature would be acceptable to implement i think.The text was updated successfully, but these errors were encountered: