Move cloudResources under jupyterhub.custom #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With hhttps://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/2200, helm will default to not allowing arbitrary extra properties anywher except under jupyterhub.custom. This helps us move towards 1.0 Ref 2i2c-org#414
11 tasks
consideRatio
approved these changes
May 16, 2021
|
Thanks, @consideRatio! Can you tell me more about what 'not-named references' are? |
|
Ah sorry, i meant to do a final search for references to the old name of the passed value: .Values.jupyterhub.cloudResources Just to check not missing out renaming a reference to that value. |
|
Ah yeah - I already did that. I used search and replace, and now I've verified it again |
|
Wieee! I pressed merge 🥳😱 |
|
yay! Thank you, @consideRatio |
damianavila
reviewed
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With jupyterhub/zero-to-jupyterhub-k8s#2200,
helm will default to not allowing arbitrary extra properties anywher
except under jupyterhub.custom. This helps us move towards 1.0
Ref #414