Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auth for binder-staging #2391

Closed

Conversation

GeorgianaElena
Copy link
Member

While manually deploying the changes in #2277, I didn't realize that we shouldn't touch 2i2c-binder-staging and that this hub doesn't get updates anymore, so I've deployed it 🤦🏼‍♀️ Then, I got sucked into debugging why we didn't manage to get authentication to work in the past and spent too much time on it, to not turn it into a PR, although I realize we want to decommission it? #2026

Developed based on @sgibson91's awesome work in #1579 ❤️

CILogon authentication now works, but I'm not sure about the binder part, as build appears to hang. @2i2c-org/engineering try it out at https://binder-staging.2i2c.cloud/

Todos left:

@GeorgianaElena
Copy link
Member Author

GeorgianaElena commented Mar 21, 2023

@sgibson91, I only checked your draft PR after I had some progress with this one, because I had totally forgot about it. Sorry for not building on top of that and opening a separate one :/

Also, looking at it again, it looks like the only thing missing there was a misplaced jupyterhub.hub.config.services instead of jupyterhub.hub.services and a cilogon client created for the binderhub url rather for the hub one pff.

@GeorgianaElena
Copy link
Member Author

Closing in favour of #2393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant