Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CILogon auth for binder-staging #2393

Merged
merged 18 commits into from
Mar 22, 2023

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Mar 21, 2023

#2391 + #1579 (I've probably done it in reverse order, as the merge wasn;t what I expected, but I've fixed it manually)

While manually deploying the changes in #2277, I didn't realize that we shouldn't touch 2i2c-binder-staging and that this hub doesn't get updates anymore, so I've deployed it 🤦🏼‍♀️ Then, I got sucked into debugging why we didn't manage to get authentication to work in the past and spent too much time on it, to not turn it into a PR, although I realize we want to decommission it? #2026

Developed based on @sgibson91's awesome work in #1579 ❤️

CILogon authentication now works, but I'm not sure about the binder part, as build appears to hang. @2i2c-org/engineering try it out at https://binder-staging.2i2c.cloud/

Todos left:

@GeorgianaElena GeorgianaElena self-assigned this Mar 21, 2023
@GeorgianaElena GeorgianaElena requested a review from a team March 21, 2023 10:56
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes I see here all makes sense and seem to me like an incremental improvement!

I see some todo notes in the PR descriptions, for example upstream contributions to binderhub docs. I think it makes sense to get this merged and offload todo notes to be tracked a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants