Allow JupyterLab to show hidden files #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change any behavior, but just allows JupyterLab to show a 'View -> Show Hidden Files' option that folks can turn on. The only reason it isn't on by default is apparently a historical accident (jupyterlab/jupyterlab#11304 (comment)) Instead of turning it on piecemeal per-hub, this just turns it on for everyone. There's no reason to not. Ref https://2i2c.freshdesk.com/a/tickets/1056
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
sgibson91
approved these changes
Oct 18, 2023
| @@ -31,14 +31,6 @@ basehub: | |||
| url: "" | |||
| custom_html: <a href="https://science.nasa.gov/heliophysics/programs/living-with-a-star/">NASA's Living with a Star program</a> and <a href="https://cpaess.ucar.edu/">UCAR/CPAESS</a> | |||
| singleuser: | |||
| extraFiles: | |||
| # FIXME: document this feature | |||
There was a problem hiding this comment.
Can we open an issue and link it here? I think FIXME notes in code like this are far too hidden for them to be properly prioritised and actioned
There was a problem hiding this comment.
@sgibson91 I was not 100% sure what exactly the 'this' refers to, but based on #3255 (comment) it's clear it's in reference to showing hidden files! So I've opened https://github.com/2i2c-org/infrastructure/issues/3285. Thanks for the catch.
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6556734525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any behavior, but just allows JupyterLab to show a 'View -> Show Hidden Files' option that folks can turn on. The only reason it isn't on by default is apparently a historical
accident (jupyterlab/jupyterlab#11304 (comment))
Instead of turning it on piecemeal per-hub, this just turns it on for everyone. There's no reason to not.
Ref https://2i2c.freshdesk.com/a/tickets/1056