Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JupyterLab to show hidden files #3282

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Allow JupyterLab to show hidden files #3282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions config/clusters/2i2c/jackeddy.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@ basehub:
url: ""
custom_html: <a href="https://science.nasa.gov/heliophysics/programs/living-with-a-star/">NASA's Living with a Star program</a> and <a href="https://cpaess.ucar.edu/">UCAR/CPAESS</a>
singleuser:
extraFiles:
# FIXME: document this feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open an issue and link it here? I think FIXME notes in code like this are far too hidden for them to be properly prioritised and actioned

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgibson91 I was not 100% sure what exactly the 'this' refers to, but based on #3255 (comment) it's clear it's in reference to showing hidden files! So I've opened https://github.com/2i2c-org/infrastructure/issues/3285. Thanks for the catch.

# Currently only documented in the context of culling https://infrastructure.2i2c.org/sre-guide/manage-k8s/culling/#kernel-culling-configuration
jupyter_notebook_config.json:
data:
# Allow jupyterlab option to show hidden files in browser
ContentsManager:
allow_hidden: true
# https://infrastructure.2i2c.org/howto/features/dedicated-nodepool/
nodeSelector:
# Applied to all profile options
Expand Down
8 changes: 0 additions & 8 deletions config/clusters/jupyter-meets-the-earth/common.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@ basehub:
url: https://jupytearth.org

singleuser:
extraFiles:
jupyter_server_config.json:
mountPath: /etc/jupyter/jupyter_notebook_config.json
data:
# Allow jupyterlab option to show hidden files in browser
# https://github.com/berkeley-dsep-infra/datahub/issues/3160
ContentsManager:
allow_hidden: true
initContainers:
# Need to explicitly set this up and copy what's in basehub/values.yaml
# as we have an extra 'shared-public' directory here.
Expand Down
8 changes: 0 additions & 8 deletions config/clusters/nasa-cryo/common.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ basehub:
- jomey

singleuser:
extraFiles:
# jupyter_server_config.json is defined by basehub, this entry adds to it
jupyter_server_config.json:
data:
ContentsManager:
# Enable showing hidden files in JupyterLab
# https://github.com/CryoInTheCloud/hub-image/issues/3
allow_hidden: true
defaultUrl: /lab
storage:
extraVolumes:
Expand Down
5 changes: 5 additions & 0 deletions helm-charts/basehub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,11 @@ jupyterhub:
# as culling the kernel will register activity,
# resetting the no_activity timer for the server as a whole
data:
# Allow JupyterLab to show the 'View -> Show Hidden Files' option
# in the menu. Defaults are not changed.
# https://github.com/jupyterlab/jupyterlab/issues/11304#issuecomment-945466766
ContentsManager:
allow_hidden: true
# MappingKernelManager configuration reference:
# https://jupyter-server.readthedocs.io/en/latest/api/jupyter_server.services.kernels.html#jupyter_server.services.kernels.kernelmanager.MappingKernelManager
#
Expand Down