Add jest no focused tests to angular #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also add task to issue board to add prettier and CI to check formatting? |
aleks3fs
approved these changes
Nov 19, 2021
Sure, very good proposal. 👍 ... |
nkrmavnar
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit:
We would like to add jest/no-focused-tests rule to the angular linting. We believe that it is a good practice that all tests that are written are also included when running tests. It also helps with preventing leaving
.skipor similar commands in code by mistake after optimising/debugging tests.2nd comit:
When saving with formatting on save on, I found out that - how ironical - our linting rules are not formatted consistently. So this commit I all about styling consistency. Before some rules were quoted with single quote and some with double. Now everything is quoted the same way.