Fix Display a warning box when the CFG contains warnings #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
user interface
run end2end
After 3liz#4226 and 3liz#4242, the warning message can generate the error `Uncaught SyntaxError: missing ) after argument list` and `Uncaught ReferenceError: lizUrls is not defined`. These error messages are generated by a quote in the warning message. To fix it, we use the Lizmap dictionnary which is a JSON version of the Dictionnary local.
rldhont
force-pushed
the
fix-project-warnings-display-message
branch
from
27794d0 to
40b518f
Compare
|
unrelated test failure about playwright, it will be fixed in #4246 |
mdouchin
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4226 and #4242, the warning message can generate the error
Uncaught SyntaxError: missing ) after argument listand
Uncaught ReferenceError: lizUrls is not defined. These error messages are generated by a quote in the warning message.To fix it, we use the Lizmap dictionnary which is a JSON version of the Dictionnary local.