Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support delete(aggregator) #3327

Merged
merged 59 commits into from
Nov 14, 2023

refact: refact delete in tablet_impl

823a2b1
Select commit
Loading
Failed to load commit list.
Merged

feat: support delete(aggregator) #3327

refact: refact delete in tablet_impl
823a2b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 24, 2023 in 0s

86.44% of diff hit (target 75.33%)

View this Pull Request on Codecov

86.44% of diff hit (target 75.33%)

Annotations

Check warning on line 113 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L112-L113

Added lines #L112 - L113 were not covered by tests

Check warning on line 231 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L231

Added line #L231 was not covered by tests

Check warning on line 235 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L235

Added line #L235 was not covered by tests

Check warning on line 270 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L270

Added line #L270 was not covered by tests

Check warning on line 273 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L273

Added line #L273 was not covered by tests

Check warning on line 346 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L345-L346

Added lines #L345 - L346 were not covered by tests

Check warning on line 350 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L349-L350

Added lines #L349 - L350 were not covered by tests

Check warning on line 357 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L354-L357

Added lines #L354 - L357 were not covered by tests

Check warning on line 361 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L360-L361

Added lines #L360 - L361 were not covered by tests

Check warning on line 369 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L368-L369

Added lines #L368 - L369 were not covered by tests

Check warning on line 374 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L374

Added line #L374 was not covered by tests

Check warning on line 393 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L392-L393

Added lines #L392 - L393 were not covered by tests

Check warning on line 427 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L427

Added line #L427 was not covered by tests

Check warning on line 1313 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L1313

Added line #L1313 was not covered by tests

Check warning on line 1317 in src/storage/aggregator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/aggregator.cc#L1317

Added line #L1317 was not covered by tests

Check warning on line 320 in src/storage/disk_table.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/disk_table.cc#L320

Added line #L320 was not covered by tests

Check warning on line 331 in src/storage/disk_table.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/disk_table.cc#L331

Added line #L331 was not covered by tests

Check warning on line 333 in src/storage/disk_table.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/disk_table.cc#L333

Added line #L333 was not covered by tests

Check warning on line 344 in src/storage/disk_table.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/disk_table.cc#L343-L344

Added lines #L343 - L344 were not covered by tests

Check warning on line 266 in src/storage/mem_table.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/storage/mem_table.cc#L266

Added line #L266 was not covered by tests

Check warning on line 1607 in src/tablet/tablet_impl.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/tablet/tablet_impl.cc#L1605-L1607

Added lines #L1605 - L1607 were not covered by tests

Check warning on line 1618 in src/tablet/tablet_impl.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/tablet/tablet_impl.cc#L1618

Added line #L1618 was not covered by tests

Check warning on line 1627 in src/tablet/tablet_impl.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/tablet/tablet_impl.cc#L1625-L1627

Added lines #L1625 - L1627 were not covered by tests

Check warning on line 1632 in src/tablet/tablet_impl.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/tablet/tablet_impl.cc#L1632

Added line #L1632 was not covered by tests

Check warning on line 1637 in src/tablet/tablet_impl.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/tablet/tablet_impl.cc#L1635-L1637

Added lines #L1635 - L1637 were not covered by tests