Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: map table column type #3723

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

aceforeverd
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 83.29718% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 74.95%. Comparing base (c2e77b2) to head (ed63fff).
Report is 1 commits behind head on main.

Files Patch % Lines
src/schema/schema_adapter.cc 82.50% 21 Missing ⚠️
src/sdk/sql_cluster_router.cc 66.66% 19 Missing ⚠️
hybridse/src/codegen/struct_ir_builder.cc 30.76% 9 Missing ⚠️
hybridse/src/codegen/insert_row_builder.cc 89.55% 7 Missing ⚠️
hybridse/src/codegen/block_ir_builder.cc 0.00% 6 Missing ⚠️
hybridse/src/codegen/map_ir_builder.cc 92.94% 6 Missing ⚠️
hybridse/src/codegen/ir_base_builder_test.h 50.00% 2 Missing ⚠️
src/sdk/sql_insert_row.cc 66.66% 2 Missing ⚠️
src/sdk/sql_insert_row.h 90.90% 2 Missing ⚠️
hybridse/include/sdk/base_impl.h 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3723      +/-   ##
============================================
+ Coverage     74.93%   74.95%   +0.01%     
  Complexity      658      658              
============================================
  Files           738      741       +3     
  Lines        133155   133490     +335     
  Branches       1380     1380              
============================================
+ Hits          99782   100059     +277     
- Misses        33069    33127      +58     
  Partials        304      304              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd force-pushed the feat-map-table-column-type branch from b0f9a74 to 69abf5b Compare January 26, 2024 02:13
@aceforeverd aceforeverd force-pushed the feat-map-table-column-type branch 3 times, most recently from 0cbbe8b to a972349 Compare January 29, 2024 15:52
@aceforeverd aceforeverd force-pushed the feat-map-table-column-type branch from a4a536e to 47ba50b Compare February 7, 2024 04:06
Copy link
Contributor

github-actions bot commented Feb 7, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 5s ⏱️ -3s
345 tests ±0  331 ✅ ±0  14 💤 ±0  0 ❌ ±0 
471 runs  ±0  457 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit ed63fff. ± Comparison against base commit c2e77b2.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Linux Test Report

 53 files  ±0   60 suites  ±0   27m 56s ⏱️ +41s
671 tests +2  651 ✅  - 10  7 💤 ±0  13 ❌ +12 
672 runs  +2  652 ✅  - 10  7 💤 ±0  13 ❌ +12 

For more details on these failures, see this check.

Results for commit ed63fff. ± Comparison against base commit c2e77b2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

HybridSE Mac Test Report

20 116 tests   - 2   20 114 ✅  - 2   8m 7s ⏱️ +11s
   256 suites +1        2 💤 ±0 
    68 files   +1        0 ❌ ±0 

Results for commit ed63fff. ± Comparison against base commit c2e77b2.

This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both.
SqlUnsupporQuery/PlannerV2ErrorTest ‑ BatchModePlanErrorTest/21
SqlUnsupporQuery/PlannerV2ErrorTest ‑ ClusterRequestModePlanErrorTest/21
SqlUnsupporQuery/PlannerV2ErrorTest ‑ RequestModePlanErrorTest/21
InsertRowBuilderTest ‑ encode

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

HybridSE Linux Test Report

20 116 tests   - 2   20 114 ✅  - 2   6m 23s ⏱️ +16s
   256 suites +1        2 💤 ±0 
    68 files   +1        0 ❌ ±0 

Results for commit ed63fff. ± Comparison against base commit c2e77b2.

This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both.
SqlUnsupporQuery/PlannerV2ErrorTest ‑ BatchModePlanErrorTest/21
SqlUnsupporQuery/PlannerV2ErrorTest ‑ ClusterRequestModePlanErrorTest/21
SqlUnsupporQuery/PlannerV2ErrorTest ‑ RequestModePlanErrorTest/21
InsertRowBuilderTest ‑ encode

♻️ This comment has been updated with latest results.

@aceforeverd aceforeverd force-pushed the feat-map-table-column-type branch 2 times, most recently from 7b5826f to a08ff65 Compare March 1, 2024 07:02
@aceforeverd aceforeverd force-pushed the feat-map-table-column-type branch from a08ff65 to ed63fff Compare March 4, 2024 13:02
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 1106259 into 4paradigm:main Mar 5, 2024
29 of 31 checks passed
@aceforeverd aceforeverd deleted the feat-map-table-column-type branch March 5, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants