More clippy fixes #349
Merged
More clippy fixes #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `rust-toolchain.toml` file with `channel` set to `"1.79.0"` - Added `rustfmt` and `clippy` components
- Modified `run_media_server` function in [bin/src/server/media.rs] - Updated `default_cluster_cert_buf` and `default_cluster_key_buf` variables in [bin/src/server/media.rs] - Modified various blocks and lines within `run_media_server` function in [bin/src/server/media.rs] - Made changes to the `test` function in [bin/src/server/media_core/src/endpoint/internal/local_track/packet_selector/video_vp9_svc.rs] - Updated the `test_simple` function with additional test cases in [packages/media_utils/src/seq_rewrite.rs] - Modified the `push` and `pop` functions in [packages/media_record/src/storage/mod.rs] - Made changes to several functions within `internal.rs` file in [packages/media_core/src/endpoint/internal.rs] - Updated bitrate allocation logic in [packages/media_core/src/endpoint/internal/bitrate_allocator/egress.rs] - Made changes to logging and refactored code in [packages/media_record/src/media.rs] - Modified the `push_opus` and `push_vpx` methods in [packages/media_record/src/media/vpx_writer.rs] - Updated the `new` and `push` functions in [packages/media_record/src/raw_record/chunk_writer.rs] - Made modifications to various functions within `video_h264_sim.rs` in [packages/media_core/src/endpoint/internal/local_track/packet_selector/video_h264_sim.rs] - Modified the test functions in [packages/media_core/src/endpoint/internal/local_track/packet_selector/video_vp8_sim.rs]
* master: feat: Refactor media server and track selection logic chore: update docs installation (8xFF#343) fixed: build release with github action (8xFF#340) Fix: github action failed to build release with c++ deps (8xFF#339) fixed: update atm0s-sdn for fix media-node failed to register gateway after restart caused by broadcast register message was rejected by history cache logic (8xFF#337) feat: media record (8xFF#329) fixed: build warnings and clippy warnings (8xFF#328)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 41.84% 41.83% -0.01%
==========================================
Files 134 134
Lines 14046 14048 +2
==========================================
Hits 5877 5877
- Misses 8169 8171 +2 ☔ View full report in Codecov by Sentry. |
- Add comment explaining the use of `clippy::map_entry` in [packages/media_record/src/media.rs] - Include link to open issue on Rust Clippy GitHub repo in the comment
giangndm
approved these changes
Jul 17, 2024
|
@dhilipsiva for avoiding clippy warns, can you add a github action for running it every pull request? |
3 tasks
giangndm
pushed a commit
to giangndm/8xFF-decentralized-media-server
that referenced
this pull request
Nov 26, 2024
* fix build warnings * refactor: fix clippy warnings * build: Set default Rust version and add code formatting tools - Added `rust-toolchain.toml` file with `channel` set to `"1.79.0"` - Added `rustfmt` and `clippy` components * chore: add a TODO comment. * chore: removed a comment that was confirmed. * refactor: #[allow(clippy::large_enum_variant)] * feat: Refactor media server and track selection logic - Modified `run_media_server` function in [bin/src/server/media.rs] - Updated `default_cluster_cert_buf` and `default_cluster_key_buf` variables in [bin/src/server/media.rs] - Modified various blocks and lines within `run_media_server` function in [bin/src/server/media.rs] - Made changes to the `test` function in [bin/src/server/media_core/src/endpoint/internal/local_track/packet_selector/video_vp9_svc.rs] - Updated the `test_simple` function with additional test cases in [packages/media_utils/src/seq_rewrite.rs] - Modified the `push` and `pop` functions in [packages/media_record/src/storage/mod.rs] - Made changes to several functions within `internal.rs` file in [packages/media_core/src/endpoint/internal.rs] - Updated bitrate allocation logic in [packages/media_core/src/endpoint/internal/bitrate_allocator/egress.rs] - Made changes to logging and refactored code in [packages/media_record/src/media.rs] - Modified the `push_opus` and `push_vpx` methods in [packages/media_record/src/media/vpx_writer.rs] - Updated the `new` and `push` functions in [packages/media_record/src/raw_record/chunk_writer.rs] - Made modifications to various functions within `video_h264_sim.rs` in [packages/media_core/src/endpoint/internal/local_track/packet_selector/video_h264_sim.rs] - Modified the test functions in [packages/media_core/src/endpoint/internal/local_track/packet_selector/video_vp8_sim.rs] * fix: error[yanked]: detected yanked crate (try `cargo update -p bytes`) * docs: Improve code documentation and clippy usage in media module - Add comment explaining the use of `clippy::map_entry` in [packages/media_record/src/media.rs] - Include link to open issue on Rust Clippy GitHub repo in the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.