Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB in SpiralIterator::operator++ #481

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 8, 2024

Forward port of #479 to fix undefined behavior

@Ryanf55 Ryanf55 added bug ros2 Affects ROS 2 labels Nov 8, 2024
@Ryanf55 Ryanf55 requested a review from wep21 November 8, 2024 05:40
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 8, 2024

Merge blocked by #482

@wep21
Copy link
Collaborator

wep21 commented Nov 27, 2024

@Ryanf55 rebase, please.

* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55 Ryanf55 merged commit 74dbbc8 into ANYbotics:rolling Nov 28, 2024
2 checks passed
@Ryanf55 Ryanf55 deleted the hotfix-spiral-iterator-ub branch November 28, 2024 02:37
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 28, 2024

@Mergifyio backport jazzy
@Mergifyio backport iron
@Mergifyio backport humble

Copy link

mergify bot commented Nov 28, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 28, 2024
* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 74dbbc8)
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 28, 2024

https://github.com/Mergifyio backport iron

Copy link

mergify bot commented Nov 28, 2024

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 28, 2024
* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 74dbbc8)
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 28, 2024

@Mergifyio backport humble

Copy link

mergify bot commented Nov 28, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 28, 2024
* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 74dbbc8)
Ryanf55 added a commit that referenced this pull request Nov 28, 2024
* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 74dbbc8)

Co-authored-by: Ryan <[email protected]>
Ryanf55 added a commit that referenced this pull request Nov 28, 2024
* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 74dbbc8)

Co-authored-by: Ryan <[email protected]>
Ryanf55 added a commit that referenced this pull request Nov 28, 2024
* Calling pop_back on an iterator past the end is UB

Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 74dbbc8)

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants