Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#126: Bring workflow actions up to date #127

Merged
merged 24 commits into from
Jun 27, 2024
Merged

#126: Bring workflow actions up to date #127

merged 24 commits into from
Jun 27, 2024

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Jun 24, 2024 •
edited
Loading

  • unified actions names and filenames
  • added test filename check
  • streamlined job steps

Closes #126

@benedeki
#126: Bring workflow actions up to date
b0c2f68 
* unified actions names and filenames
* added test filename check
* streamlined job steps
@benedeki benedeki added work in progress Work on this item is not yet finished (mainly intended for PRs) no RN No release notes required labels Jun 24, 2024
@lsulak
Copy link
Collaborator

lsulak commented Jun 24, 2024 •
edited
Loading

What about RN check, as was done in https://github.com/AbsaOSS/atum-service/pull/212/files ?

actually even release.yml is quite old, I mean the whole pipeline and its approach

@benedeki
Copy link
Contributor Author

What about RN check, as was done in https://github.com/AbsaOSS/atum-service/pull/212/files ?

actually even release.yml is quite old, I mean the whole pipeline and its approach

Talked to @miroslavpojer. He's heavily working a new, better solution for the release notes. He suggest not to implement the old thing on any other repo.

@benedeki benedeki added dependent The item depends on some other open item (Issue or PR) and removed dependent The item depends on some other open item (Issue or PR) labels Jun 25, 2024
miroslavpojer
miroslavpojer reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@miroslavpojer miroslavpojer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code review

.github/workflows/jacoco_report.yml Outdated
@@ -62,8 +60,8 @@ jobs:
paths: >
${{ github.workspace }}/core/target/scala-${{ env.SCALA_SHORT_VERSION }}/jacoco/report/jacoco.xml
token: ${{ secrets.GITHUB_TOKEN }}
min-coverage-overall: ${{ env.COVERAGE_OVERALL_EXPECTATION }}
min-coverage-changed-files: ${{ env.COVERAGE_CHANGED_EXPECTATION }}
min-coverage-overall: ${{ 57.0 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are {{ }} still needed if inside is a number?
I believe we talked about removing these constants, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I pointed to 1st location where I saw it. This is on more locations in yml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely rewritten.

publish.sbt
)
)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two empty lines?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 57.44% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 81.6% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo slick module code coverage report - scala 2.13.11

Overall Project 87.73% 🍏

There is no coverage information present for the Files changed

@benedeki benedeki removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Jun 26, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Jun 27, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Jun 27, 2024
@AbsaOSS AbsaOSS deleted a comment from github-actions bot Jun 27, 2024
miroslavpojer
miroslavpojer approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last idea: how about overall values per module? There are big differences.

@benedeki
Copy link
Contributor Author

Last idea: how about overall values per module? There are big differences.

This is already a long workflow, with a proclivity for typo errors or omitting stuff (like modules).
A creation of dedicated action is the way to go forward.

@benedeki benedeki merged commit d459a60 into master Jun 27, 2024
7 checks passed
@benedeki benedeki deleted the feature/126-bring-worklow-actions-up-to-date branch June 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak left review comments

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@jakipatryk jakipatryk Awaiting requested review from jakipatryk jakipatryk is a code owner

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees
No one assigned
Labels
no RN No release notes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring workflow actions up to date
3 participants
@benedeki @lsulak @miroslavpojer