-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#126: Bring workflow actions up to date #127
Merged
benedeki
merged 24 commits into
master
from
feature/126-bring-worklow-actions-up-to-date
Jun 27, 2024
Merged
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b0c2f68
#126: Bring workflow actions up to date
benedeki 11c8d83
* added check filename exceptions
benedeki 42e5bad
* decreased overall test coverage required
benedeki 16e3ebd
* Fixed Jacoco checks to use the constants
benedeki 01e0096
Merge branch 'master' into feature/126-bring-worklow-actions-up-to-date
benedeki 69e88bf
* better coverage report log
benedeki 150d23e
* New test filename exception
benedeki 2338517
* experiment
benedeki c9622ae
* rollback of experiment
benedeki aef4699
* revert experiment II
benedeki ae9b37f
* F
benedeki 3520658
* using Number()
benedeki 1bcf3e9
* return to first version but with values hardcoded
benedeki eb41e8d
* JaCoCo report last touches (hopefully)
benedeki 878db7f
* one more
benedeki 7b5758e
* ..!
benedeki 1a66392
* 57
benedeki 8dc0687
* title
benedeki c153690
* 57 second time
benedeki ff55b0d
Update jacoco_report.yml - PR comments
benedeki 824e160
* JaCoCo action rewritten
benedeki d64c169
* fixed test db name
benedeki 32fc497
* testing
benedeki afeee7c
* testing finished
benedeki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
* @benedeki @dk1844 @jakipatryk @lsulak @Zejnilovic | ||
* @benedeki @dk1844 @jakipatryk @lsulak @Zejnilovic @salamonpavel @miroslavpojer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: Auto Assign Issue to Project | ||
name: Assign Issue to Project | ||
|
||
on: | ||
issues: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,8 @@ on: | |
types: [ assigned, opened, synchronize, reopened, labeled ] | ||
|
||
jobs: | ||
build: | ||
build-test-and-doc: | ||
name: Build, Test and Doc | ||
runs-on: ubuntu-latest | ||
services: | ||
postgres: | ||
|
@@ -42,7 +43,6 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
scala: [2.12.17, 2.13.12] | ||
name: Build and test | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
|
@@ -52,7 +52,9 @@ jobs: | |
java-version: "[email protected]" | ||
- name: Build and run unit tests | ||
run: sbt ++${{matrix.scala}} test | ||
- name: Generate documentation | ||
run: sbt ++${{matrix.scala}} doc | ||
- name: Prepare testing database | ||
run: sbt flywayMigrate | ||
- name: Build and run integration tests | ||
run: sbt ++${{matrix.scala}} testIT doc | ||
- name: Run integration tests | ||
run: sbt ++${{matrix.scala}} testIT |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: Dependent Issues | ||
name: Dependent Items | ||
|
||
on: | ||
issues: | ||
|
@@ -24,7 +24,8 @@ on: | |
- cron: '0 0 * * *' | ||
|
||
jobs: | ||
check: | ||
dependent-items-check: | ||
name: Dependent Items Check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: z0al/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# | ||
# Copyright 2022 ABSA Group Limited | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
name: Test Filenames Check | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
types: [ opened, synchronize, reopened ] | ||
|
||
jobs: | ||
test_filenames_check: | ||
name: Test Filenames Check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
|
||
- name: Filename Inspector | ||
id: scan-test-files | ||
uses: AbsaOSS/filename-inspector@master | ||
with: | ||
name-patterns: '*UnitTests.*,*IntegrationTests.*' | ||
paths: '**/src/test/scala/**' | ||
report-format: 'console' | ||
excludes: 'slick/src/test/scala/za/co/absa/fadb/slick/Actor.scala,slick/src/test/scala/za/co/absa/fadb/slick/ActorSlickConverter.scala,slick/src/test/scala/za/co/absa/fadb/slick/SlickTest.scala,doobie/src/test/scala/za/co/absa/fadb/doobie/DoobieTest.scala,slick/src/test/scala/za/co/absa/fadb/slick/OptionalActorSlickConverter.scala' | ||
verbose-logging: 'false' | ||
fail-on-violation: 'true' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,9 +32,34 @@ ThisBuild / developers := List( | |
name = "David Benedeki", | ||
email = "[email protected]", | ||
url = url("https://github.com/benedeki") | ||
), | ||
Developer( | ||
id = "lsulak", | ||
name = "Ladislav Sulak", | ||
email = "[email protected]", | ||
url = url("https://github.com/lsulak") | ||
), | ||
Developer( | ||
id = "salamonpavel", | ||
name = "Pavel Salamon", | ||
email = "[email protected]", | ||
url = url("https://github.com/salamonpavel") | ||
), | ||
Developer( | ||
id = "miroslavpojer", | ||
name = "Miroslav Pojer", | ||
email = "[email protected]", | ||
url = url("https://github.com/miroslavpojer") | ||
), | ||
Developer( | ||
id = "Zejnilovic", | ||
name = "Saša Zejnilović", | ||
email = "[email protected]", | ||
url = url("https://github.com/Zejnilovic") | ||
) | ||
) | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Two empty lines? |
||
ThisBuild / homepage := Some(url("https://github.com/AbsaOSS/fa-DB")) | ||
ThisBuild / description := "DB data access via DB functions" | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are {{ }} still needed if inside is a number?
I believe we talked about removing these constants, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I pointed to 1st location where I saw it. This is on more locations in yml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely rewritten.