Parse NAs when reading in json files #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyhawkins
added a commit
that referenced
this pull request
Oct 26, 2023
Parse NAs when reading in json files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing projects with
v0.6.0, I noticed that projects that don't contain a submitter cell types file were throwing an error when trying to find the submitter cell types file designated asNA. This is because if we skip mapping, we read in the meta fromscpca-meta.json, rather than using themetaobject we create fromscpca-library-metadata.tsv. We had previously only been handling the NAs when reading in the metadata file, not the json file. This PR makes the fix to handle NA's when reading in json too.I tested this with a run that doesn't have a submitter cell types file and it worked successfully. I also am filing this to
main, because I want to create a new release with these changes only. I will file the same PR to thedevelopmentbranch to keep things in sync after this is approved.