Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data model bindings #11646

Merged
merged 3 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,14 @@ describe('InputActionWrapper', () => {
await act(() => user.hover(input));
expect(screen.getByLabelText('general.edit')).toBeInTheDocument();
});

it('renders right actions when switching mode', async () => {
const { rerender } = await rtlRender(<InputActionWrapper {...mockProps} mode={'editMode'} />);
expect(screen.getByLabelText('general.save')).toBeInTheDocument();
expect(screen.getByLabelText('general.delete')).toBeInTheDocument();

rerender(<InputActionWrapper {...mockProps} mode={'hoverMode'} />);
expect(screen.getByLabelText('general.edit')).toBeInTheDocument();
expect(screen.getByLabelText('general.delete')).toBeInTheDocument();
});
});
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';
import { CheckmarkIcon, TrashIcon, PencilWritingIcon } from '@altinn/icons';
import { useText } from '../../../../ux-editor/src/hooks/index';
import { Button, ButtonProps } from '@digdir/design-system-react';
Expand Down Expand Up @@ -36,7 +36,12 @@ export const InputActionWrapper = ({
...rest
}: InputActionWrapperProps): JSX.Element => {
const t = useText();
const [actions, setActions] = useState<AvailableAction[]>(actionGroupMap[mode || 'standBy']);
const defaultActions = actionGroupMap[mode || 'standBy'];
const [actions, setActions] = useState<AvailableAction[]>(defaultActions);

useEffect(() => {
setActions(defaultActions);
}, [defaultActions]);

const handleFocus = (): void => {
setActions(actionGroupMap['editMode']);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const render = async ({
},
};

renderWithMockStore(
return renderWithMockStore(
{ appData },
{ getDatamodelMetadata },
handleDataModelChange(),
Expand Down Expand Up @@ -273,4 +273,23 @@ describe('EditDataModelBindings', () => {
expect(editIcon).toBeInTheDocument();
expect(onEditClick).toHaveBeenCalled;
});

it('show right data model when switching component', async () => {
const { renderResult } = await render({
dataModelBindings: { simpleBinding: 'testModel.field1' },
});
expect(await screen.findByText('testModel.field1')).toBeInTheDocument();
renderResult.rerender(
<EditDataModelBindings
handleComponentChange={jest.fn()}
component={{
id: 'someComponentId',
type: ComponentType.Input,
dataModelBindings: { simpleBinding: 'testModel.field2' },
itemType: 'COMPONENT',
}}
/>,
);
expect(await screen.findByText('testModel.field2')).toBeInTheDocument();
});
});
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { IGenericEditComponent } from '../componentConfig';
import { getMinOccursFromDataModel, getXsdDataTypeFromDataModel } from '../../../utils/datamodel';
import { ComponentType } from 'app-shared/types/ComponentType';
import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';
import { useText } from '../../../hooks';
import { SelectDataModelComponent } from '../SelectDataModelComponent';
import { useDatamodelMetadataQuery } from '../../../hooks/queries/useDatamodelMetadataQuery';
Expand Down Expand Up @@ -49,9 +49,14 @@ export const EditDataModelBindings = ({
const { uniqueKey, key, label } = renderOptions || {};

const [dataModelSelectVisible, setDataModelSelectVisible] = useState(false);
const [selectedOption, setSelectedOption] = useState<string | undefined>(
component.dataModelBindings ? component.dataModelBindings[key || 'simpleBinding'] : undefined,
);

useEffect(() => {
setDataModelSelectVisible(false);
}, [component.id]);

const selectedOption = component.dataModelBindings
? component.dataModelBindings[key || 'simpleBinding']
: undefined;

return (
<div key={uniqueKey || ''}>
Expand All @@ -69,7 +74,6 @@ export const EditDataModelBindings = ({
onDeleteClick={() => {
handleDataModelChange('', key);
setDataModelSelectVisible(false);
setSelectedOption(undefined);
}}
onSaveClick={() => setDataModelSelectVisible(false)}
>
Expand All @@ -95,7 +99,6 @@ export const EditDataModelBindings = ({
}
onDataModelChange={(dataModelField: string) => {
handleDataModelChange(dataModelField, key);
setSelectedOption(dataModelField);
}}
noOptionsMessage={t('general.no_options')}
helpText={helpText}
Expand Down
4 changes: 3 additions & 1 deletion frontend/packages/ux-editor/src/testing/mocks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ export const renderWithMockStore =
storeCreator,
});
const renderResult = render(renderComponent(component));
return { renderResult, store };
const rerender = (rerenderedComponent) =>
renderResult.rerender(renderComponent(rerenderedComponent));
return { renderResult: { ...renderResult, rerender }, store };
};

export const renderHookWithMockStore =
Expand Down