Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app-lib-dotnet to dotnet8 with c# 12 #340

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update app-lib-dotnet to dotnet8 with c# 12 #340

merged 2 commits into from
Nov 16, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 6, 2023

We should ensure that v8 works with the newest dotnet version, which at the time of release of app-lib v8 will be net8.0.

If someone finds a compelling idea for why we would need multi-targeting net6.0 (or net7.0), I'm not against it, but forcing users to have similar setup and not have to ask (Oh, you run net6.0, we didn't properly test that) is a huge time saver in my opinion.

This PR does not include the fix of the update tool to change dotnet version, as it would conflict with changes in #329

Related Issue(s)

  • No separate issue

Remarks

Something funny happened with FeatureManagment when updating, and I had to use the newest version to make the tests compile. Seems like a very sensible change.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne ivarne added this to the 8.0.0 milestone Nov 6, 2023
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any reason for supporting multi targeting for v8 either

@ivarne ivarne merged commit 0fe6d08 into v8 Nov 16, 2023
8 checks passed
@ivarne ivarne deleted the ivarne/useDotnet8 branch November 16, 2023 06:46
@tjololo tjololo added the breaking-change Label Pull requests with breaking changes. Used when generating releasenotes label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants