Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cran comments for 0.10.4 #139

Merged
merged 4 commits into from
Sep 3, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# box.linters 0.10.4

## Authors comment

This release contains fixes for two critical bugs that affect all users of the package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that this is the reason why we do another release so fast after the last one (plus some polite words).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to say "done".


The first bugfix is for a destructive bug of our styling function. If it encounters an R script file without any `box::use()` calls, it replaces all lines with `NA`.

The second is a fix for a bug that only exists on MacOS and R versions >= 4.3.0. Installing `box.linters` from CRAN behaves differently from doing a `devtools::install_local()`. We check for package dependencies (`treesitter` and `treesitter.r`). We then disable the `namespaced_function_calls()` linter if these dependencies are not available. This method to disable the linter fails when installing from CRAN on MacOS and R >= 4.3.0, and causes `lintr` to throw an error. It, however, works fine when installed from local.

# box.linters 0.10.3

## Authors comment
Expand Down
Loading