-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cran comments for 0.10.4 #139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 24 24
Lines 1125 1125
=======================================
Hits 1088 1088
Misses 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add all the remaining pre-release modifications to this PR?
- change version from develop in NEWS.md
- update version in DESCRIPTION
cran-comments.md
Outdated
|
||
## Authors comment | ||
|
||
This release contains fixes for two critical bugs that affect all users of the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add that this is the reason why we do another release so fast after the last one (plus some polite words).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to say "done".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you read the Contributing Guidelines?
Issue #
Description
Clear and concise description of what changed and why.
If necessary, include screenshots and/or a step-by-step guide on how to test the changes.
Definition of Done
R CMD check
, linter, unit tests, spelling)..Rd
files withroxygen2::roxygenise()
)