Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cran comments for 0.10.4 #139

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Aug 28, 2024

Have you read the Contributing Guidelines?

Issue #

Description

Clear and concise description of what changed and why.
If necessary, include screenshots and/or a step-by-step guide on how to test the changes.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@radbasa radbasa requested a review from jakubnowicki August 28, 2024 14:37
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (f766290) to head (a809a60).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          24       24           
  Lines        1125     1125           
=======================================
  Hits         1088     1088           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add all the remaining pre-release modifications to this PR?

  • change version from develop in NEWS.md
  • update version in DESCRIPTION

cran-comments.md Outdated

## Authors comment

This release contains fixes for two critical bugs that affect all users of the package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that this is the reason why we do another release so fast after the last one (plus some polite words).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to say "done".

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubnowicki jakubnowicki merged commit 79e3fa9 into main Sep 3, 2024
7 checks passed
@jakubnowicki jakubnowicki deleted the cran-comments-macos-r-ver-issue branch September 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants