Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cran comments for 0.10.4 #139

Merged
merged 4 commits into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: box.linters
Title: Linters for 'box' Modules
Version: 0.10.3.9001
Version: 0.10.4
Authors@R:
c(
person("Ricardo Rodrigo", "Basa", role = c("aut", "cre"), email = "[email protected]"),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# box.linters (development version)
# box.linters 0.10.4

* Fix critical bug of style_box_use_*() converting all lines to NA if there is no `box::use()` call found.
* R version (>= 4.3.0) compatibility fix for MacOS.
Expand Down
10 changes: 10 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# box.linters 0.10.4

## Authors comment

This release contains fixes for two critical bugs that affect all users of the package. In light of this, we humbly appeal to the reviewer to consider this release. We understand that the last submission was very recent, and we apologize for submitting a publish request soon after the last.

The first bugfix is for a destructive bug of our styling function. If it encounters an R script file without any `box::use()` calls, it replaces all lines with `NA`.

The second is a fix for a bug that only exists on MacOS and R versions >= 4.3.0. Installing `box.linters` from CRAN behaves differently from doing a `devtools::install_local()`. We check for package dependencies (`treesitter` and `treesitter.r`). We then disable the `namespaced_function_calls()` linter if these dependencies are not available. This method to disable the linter fails when installing from CRAN on MacOS and R >= 4.3.0, and causes `lintr` to throw an error. It, however, works fine when installed from local.

# box.linters 0.10.3

## Authors comment
Expand Down
Loading