Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutual Checker, NotificationBlock, Quote Replies: Some notifications are not processed #1658

Open
marcustyphoon opened this issue Dec 5, 2024 · 3 comments · May be fixed by #1659
Open

Mutual Checker, NotificationBlock, Quote Replies: Some notifications are not processed #1658

marcustyphoon opened this issue Dec 5, 2024 · 3 comments · May be fixed by #1659
Assignees
@marcustyphoon
Labels
bug Something isn't working

Comments

@marcustyphoon
Copy link
Collaborator

marcustyphoon commented Dec 5, 2024 •
edited
Loading

There appears to be a tweaked Tumblr notification element type* which is only used sometimes and which does not match our notificationSelector. This breaks Quote Replies, as per the quoted comment, as well (I think) as Mutual Checker and NotificationBlock on those notifications.

*Edit: Ah, I see this is not just a frontend change; the information provided by the backend has changed as well. This may require some nontrivial code rewriting, particularly for Quote Replies.

hello! I'm also finding that though I've refreshed, toggled off/on, that I'm unable to even see the option to click in order to use quote replies. Now it's been awhile since I've used the feature, so I don't fully remember how it works, but I'm really not getting anything showing in order to do it, I'm wondering if it's something that could have been broken when tumblr implemented their new way of replying to replies within the replies?
image
image
image

Originally posted by @lauraxjane in #1655 (comment)
@marcustyphoon marcustyphoon mentioned this issue Dec 5, 2024
Closed
@marcustyphoon
Copy link
Collaborator Author

Notably, this currently causes some activity elements to have [role="listitem"] and others not ([role="listitem"] { outline: 5px double red; outline-offset: -5px } looks pretty silly), which is probably an oversight on Tumblr's part.

@marcustyphoon marcustyphoon pinned this issue Dec 5, 2024
@lauraxjane
Copy link

I'm not gonna lie, I know only the basics of general html coding, like for tumblr themes, is this something I should be able to edit myself or is it something that is requiring a fix on the extension's end? so sorry to be kinda dumb here! but appreciate any and all help, thank you!

@marcustyphoon
Copy link
Collaborator Author

No worries! Yes, this will require (a lot of) work on the extension side to fix. Looking into it!

@marcustyphoon marcustyphoon linked a pull request Dec 5, 2024 that will close this issue
Open
@AprilSylph AprilSylph added the bug Something isn't working label Dec 5, 2024
@marcustyphoon marcustyphoon mentioned this issue Dec 9, 2024
Open
@marcustyphoon marcustyphoon changed the title Some notifications are not processed Mutual Checker, NotificationBlock, Quote Replies: Some notifications are not processed Dec 9, 2024
@marcustyphoon marcustyphoon mentioned this issue Dec 10, 2024
Draft
This was referenced Jan 7, 2025
Closed
Merged
@marcustyphoon marcustyphoon linked a pull request Feb 13, 2025 that will close this issue
Mutual Checker, NotificationBlock, Quote Replies: Process new reply format #1659
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcustyphoon marcustyphoon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@marcustyphoon @AprilSylph @lauraxjane