Quote Replies: Add action buttons to replies in post notes #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man, I wish I had typescript and something similar to Zod. I mean, jesus. |
This comment was marked as resolved.
This comment was marked as resolved.
|
q: why did you make a PR that would immediately completely explode when it's merged with another active PR? |
marcustyphoon
force-pushed
the
quote-replies-post-notes
branch
from
a16b5f8 to
551bf9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bit of an aside to the actual issue in question, #1655 (comment) also brought up that it's reasonable to expect Quote Replies to be usable from the replies themselves as well as the activity pane. It isn't... but we can probably do that!
As a bonus, this sidesteps #1658, since the post notes API is totally different.
Description
todo: explain technical details
Testing steps