Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meatballs util: Refactor; remove duplicate code #1712

Merged

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jan 27, 2025

Description

This cleans up a big chunk of copy-pasted code that was added to the meatballs util in #910, making the addition of meatball menu items generic over different types (post, blog). This makes it easier to add additional types of meatball menu to target (#1662).

Testing steps

  • Confirm that PostBlock/Mirror Posts meatball items work correctly.
  • Confirm that NotificationBlock meatball items only appear on user posts and work correctly.
  • Merge New Script: Mute #677 into this PR and confirm that blog meatball items work correctly.

@marcustyphoon marcustyphoon self-assigned this Jan 27, 2025
that's not how that works huh
@marcustyphoon marcustyphoon marked this pull request as ready for review January 30, 2025 12:53
@marcustyphoon marcustyphoon removed their assignment Jan 30, 2025
@marcustyphoon marcustyphoon merged commit 169986a into AprilSylph:master Feb 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants