Add MCU monitoring through ADC3 for H750 and H730 based boards #23599
Conversation
bugobliterator
force-pushed
the
pr-adc-h750-monitoring
branch
2 times, most recently
from
d5b2614 to
8afda8c
Compare
|
@bugobliterator can you make the merge base your other PR? Difficult to review otherwise |
bugobliterator
force-pushed
the
pr-adc-h750-monitoring
branch
from
8afda8c to
4acfe11
Compare
|
@andyp1per this PR is ready for your review and testing |
| @@ -76,6 +76,10 @@ | |||
|
|
|||
| 'DEFINES' : { | |||
| 'HAL_HAVE_HARDWARE_DOUBLE' : '1', | |||
| 'HAL_WITH_MCU_MONITORING' : '1', | |||
There was a problem hiding this comment.
These are correct for the H730 not the H750 which is essentially the same as the H743
There was a problem hiding this comment.
In that case, should we add a separate python script for H730?
There was a problem hiding this comment.
@andyp1per feel free to push changes to this branch. I think you have the hardware where you can test this.
There was a problem hiding this comment.
😄 @bugobliterator there is a separate python script fro H730
don't think I can push to this branch, but will try
andyp1per
force-pushed
the
pr-adc-h750-monitoring
branch
from
4acfe11 to
8e961f9
Compare
andyp1per
changed the title
|
@bugobliterator I've pushed the changes but I don't think they work because ADC3 on STM32H730 is 12bit only and it looks like the code assumes 16bit. Also ADC3 is not enabled in ChibiOS so we need to ask Giovanni about that. |
As promised here #22671 , requires that PR to be merged in first.