-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_Linux: support UNIX FIFO(named pipe) interface #24321
Conversation
4627aad
to
3305be7
Compare
I don't see the motivation anywhere. What's the use case here? |
Overall looks good. I left some comments and would like to have a justification for this support. |
3305be7
to
88f6bb8
Compare
I use this to do simple I/O logging with tee. I also use it to provide a connection like a virtual serial port with flow control to connect to another program on the same device. I'm using OpenHD for forwarding MAVLink over raw(IP-less) 802.11 frames. |
88f6bb8
to
bc644ed
Compare
Add a new serial port type backed by a pair of UNIX FIFOs, one for each direction. This can be used to externally monitor I/O between ArduPilot and a device attached to a serial port. This can also be used to communicate between two programs running on the same device, similar to a virtual serial port.
bc644ed
to
4a85d1d
Compare
I'm sorry about that, I accidentally pushed an old branch. I've addressed your comments and am rebuilding to test now. |
This is the correct patch and works well. However, I think I've found something I'll need to address. If the pipe is closed, ardupilot will have one thread always busy failing to access them. This might take me a bit to get to. Let me know if you prefer I close this and reopen later. |
OpenHD added more fully-featured MavLink networking, so this is no longer needed. |
Create a new serial device backend that connects to a pair(RX/TX) of named pipes.