Tools : Added custom ROS-2 service definition for switching drive modes #24705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshPratap
force-pushed
the
modeSwitchSrv
branch
from
f1a44c3 to
a349ad4
Compare
arshPratap
force-pushed
the
modeSwitchSrv
branch
from
a349ad4 to
82ac1b6
Compare
Ryanf55
requested changes
Aug 19, 2023
srmainwaring
suggested changes
Aug 20, 2023
tridge
requested changes
Aug 25, 2023
arshPratap
force-pushed
the
modeSwitchSrv
branch
2 times, most recently
from
c838a10 to
30c3281
Compare
|
@Ryanf55 @tridge @srmainwaring thanks for the review..have made the changes..Thanks..would like to know your thoughts |
|
@arshPratap - LGTM. You've addressed the issues raised by tridge and Ryan. |
srmainwaring
approved these changes
Aug 28, 2023
arshPratap
changed the title
|
@Ryanf55 looks good to me, you OK with the changes? |
arshPratap
force-pushed
the
modeSwitchSrv
branch
from
127dbdf to
aa4619c
Compare
Thanks @tridge .. Have made the changes |
Ryanf55
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom ROS-2 service definition for switching drive modes.
Service definition used from here
@Ryanf55 @srmainwaring @tridge