Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: Run autoupdate #24728

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Aug 22, 2023

This should fix the issue of not being able to commit on older branches when using pre-commit once installed. If we want to help out developers working on old releases, this would require a backport of the pre-commit config. This is super low risk to the release, and I don't see it needing a beta, since pre-commit is only used when changing code, and does not affect any flight behavior.

To do this on a release branch, you can see running the autoupdate brings in the new isort version which has the fix for the poetry error.

ryan@ryan-B650-970:~/Development/ardu_ws/src/ardupilot$ pre-commit autoupdate
[https://github.com/pre-commit/pre-commit-hooks] updating v4.2.0 -> v4.4.0
[https://github.com/pycqa/isort] updating 5.10.1 -> 5.12.0
[https://github.com/pre-commit/mirrors-mypy] updating v0.950 -> v1.5.1

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use isort, so not an issue for now !

No risk from this update.
This only impact developpers that are using pre-commit as a precommit git hooks. Otherwise, it won't matter if you change branch

@tridge tridge merged commit 9e330b2 into ArduPilot:master Aug 29, 2023
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Aug 29, 2023

@Ryanf55 Backport this up to 4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants