AP_Mount: SWITCH statement to table reference #24992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Sep 16, 2023
libraries/AP_Mount/AP_Mount_Siyi.cpp
Outdated
| cam_image_type = CameraImageType::MAIN_THERMAL_SUB_WIDEANGLE; // 8 | ||
| break; | ||
| } | ||
| static CameraImageType cam_image_type_table[9] = { |
There was a problem hiding this comment.
Suggested change
| static CameraImageType cam_image_type_table[9] = { | |
| static const CameraImageType cam_image_type_table[] { |
peterbarker
force-pushed
the
AP_SWITCH_statement_to_table_reference
branch
from
f3f25d8 to
8e89542
Compare
peterbarker
approved these changes
Jul 10, 2024
|
This LGTM, but Randy should have a look since he's playing with the Siyi driver ATM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would change to a type table with LEN values as indices.
No more decisions will be necessary.