Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_HAL_ChibiOS: added PixPilot-C3 #25111

Merged
merged 2 commits into from
Nov 10, 2023
Merged

AP_HAL_ChibiOS: added PixPilot-C3 #25111

merged 2 commits into from
Nov 10, 2023

Conversation

Cedric0489
Copy link
Contributor

No description provided.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Sep 27, 2023
Hwurzburg
Hwurzburg requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your wiki page submission (thanks for that) states that the buzzer is integrated on board....have you tested to make sure buzzer does not cause vibration of IMUs?? this can be a serious issue....

Tools/AP_Bootloader/board_types.txt Outdated Show resolved Hide resolved
@Cedric0489
Copy link
Contributor Author

your wiki page submission (thanks for that) states that the buzzer is integrated on board....have you tested to make sure buzzer does not cause vibration of IMUs?? this can be a serious issue....

We have tested the vibration caused by the buzzer and its impact on imus is negligible.

@Cedric0489 Cedric0489 requested a review from Hwurzburg October 7, 2023 08:36
Hwurzburg
Hwurzburg approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still have a conflict...are you finished testing and ready for this to be merged?

@Cedric0489
Copy link
Contributor Author

still have a conflict...are you finished testing and ready for this to be merged?

Yes, we are done testing and ready to merge.

@Hwurzburg
Copy link
Collaborator

@Cedric0489 I fixed the merge conflict, corrected the commit messages, and added a dev call tag

tridge
tridge requested changes Nov 8, 2023
View reviewed changes
Tools/AP_Bootloader/board_types.txt Outdated Show resolved Hide resolved
@tridge tridge removed the DevCallEU label Nov 8, 2023
@peterbarker peterbarker merged commit 63c1981 into ArduPilot:master Nov 10, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg approved these changes

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cedric0489 @Hwurzburg @tridge @peterbarker