AP_Baro: Check if origin alt is zero before using it as field elevation #25114
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Sep 27, 2023
rishabsingh3003
force-pushed
the
baro_field_elevation
branch
from
5586af9 to
5fda953
Compare
|
@rishabsingh3003 i think better to make _field_elevation_active equal to 0.001 if it is exactly zero when set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If origin is set with height 0, then field elevation keeps getting set at 1hz. This is easily reproducible in SITL by switching off the GPS (or any other pos source) and setting the origin (without height).
I am not sure if this is the correct solution though