Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle "Reset Mission" param in DO_SET_MISSION_CURRENT command #25130

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Handle "Reset Mission" param in DO_SET_MISSION_CURRENT command #25130

merged 8 commits into from
Nov 13, 2023

Conversation

nexton-winjeel
Copy link
Contributor

This PR adds handling for param2 ("Reset Mission") in the DO_SET_MISSION_CURRENT command.

@nexton-winjeel
Copy link
Contributor Author

Our use case for this is being able to restart a completed mission without having to exit and re-enter AUTO mode.

peterbarker
peterbarker reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autotest?

This PR seems to do more than the title would imply.

@nexton-winjeel nexton-winjeel force-pushed the upstream/handle-reset-param-in-DO_SET_MISSION_CURRENT branch from a4aa3fd to 847b085 Compare October 9, 2023 00:08
@nexton-winjeel
Copy link
Contributor Author

nexton-winjeel commented Oct 9, 2023 •
edited
Loading

Autotest?

This PR seems to do more than the title would imply.

@peterbarker: I've added some autotests for both:

  • the new changes handling the reset param of DO_SET_MISSION_CURRENT; and
  • the verification of the seq/tag params on DO_SET_MISSION_CURRENT and DO_JUMP_TAG.

@nexton-winjeel
Copy link
Contributor Author

nexton-winjeel commented Oct 9, 2023 •
edited
Loading

@peterbarker: The changes to AP_Mission also partially address #18528 and #18561.

@nexton-winjeel nexton-winjeel force-pushed the upstream/handle-reset-param-in-DO_SET_MISSION_CURRENT branch from 847b085 to e51b4d7 Compare October 9, 2023 01:34
@nexton-winjeel
Copy link
Contributor Author

Fixed flake8 compliance.

@nexton-winjeel nexton-winjeel force-pushed the upstream/handle-reset-param-in-DO_SET_MISSION_CURRENT branch from e51b4d7 to 8c41246 Compare October 13, 2023 00:26
@nexton-winjeel nexton-winjeel force-pushed the upstream/handle-reset-param-in-DO_SET_MISSION_CURRENT branch from 8c41246 to 8fb81d1 Compare November 10, 2023 00:48
@tridge tridge merged commit 55d7965 into ArduPilot:master Nov 13, 2023
86 checks passed
@nexton-winjeel nexton-winjeel deleted the upstream/handle-reset-param-in-DO_SET_MISSION_CURRENT branch November 13, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

@peterbarker peterbarker Awaiting requested review from peterbarker

Assignees
No one assigned
Labels
Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nexton-winjeel @tridge @peterbarker @CraigElder @joshanne