Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: Allow a ICE start even if disable while disarmed is set #25138

Merged

Conversation

WickedShell
Copy link
Contributor

@WickedShell WickedShell commented Sep 28, 2023

This allows you to bypass the disable starting while disarmed option in #25053 once. The workflow this enables is as follows:

  1. Start with a disarmed/safety enabled aircraft
  2. Disable the safety switch (physically or with software)
  3. Preform inspections of the fixed wing flight control surfaces/motor test as desired
  4. Send the MAVLink command (or jump via the mission) to allow starting while disarmed
  5. Start the engine, preform engine checks
  6. Arm the aircraft and start the flight.

The main target here is the minimization of risk as we move through the system. When inspecting the fixed wing surfaces we don't want to risk starting the ICE engine, but when we get to starting it we'd actually like to be disarmed, as that stops us from risking taking off by accident or flying the mission.

This had been tested before, but it has since been cherry-picked and rebased, so I need to actually retest this with hardware. This needs an accompanying MAVLink commit to define the usage of param4. (I'm planning to use it as an options bit mask).

Accompanying MAVLink PR is ArduPilot/mavlink#331

Copy link
Contributor Author

@WickedShell WickedShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagged some things I think need to be fixed, but wanted to get some general feedback.

libraries/AP_ICEngine/AP_ICEngine.cpp Outdated Show resolved Hide resolved
libraries/AP_Mission/AP_Mission.h Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Oct 16, 2023

@WickedShell doesn't build

@WickedShell WickedShell force-pushed the wickedshell/engine-disarmed-start branch from 4856ab6 to 7eff6f6 Compare October 23, 2023 17:43
@WickedShell
Copy link
Contributor Author

Rebased, pulled the MAVLink change in, tested with sending the message from a GCS, as well as through a mission.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Oct 23, 2023
@WickedShell WickedShell merged commit 15666fa into ArduPilot:master Oct 24, 2023
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants