AP_DDS: use generated types for service serialisation #25148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the generated types from
ardupilot_msgs
to de-serialise and serialise the requests and responses for the arm motors and mode switch services. This allows the generated serialisation code to handle byte alignment etc.Testing
Run the iris runway world:
Run MAVProxy:
Switch mode to GUIDED (=4)
$ ros2 service call /ap/mode_switch ardupilot_msgs/srv/ModeSwitch "{mode: 4}" requester: making request: ardupilot_msgs.srv.ModeSwitch_Request(mode=4) response: ardupilot_msgs.srv.ModeSwitch_Response(status=True, curr_mode=4)
Arm motors:
$ ros2 service call /ap/arm_motors ardupilot_msgs/srv/ArmMotors "{arm: true}" requester: making request: ardupilot_msgs.srv.ArmMotors_Request(arm=True) response: ardupilot_msgs.srv.ArmMotors_Response(result=True)