Guard against compilation errors when features missing #25150
+122
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Sep 29, 2023
libraries/AP_AHRS/AP_AHRS_Backend.h
Outdated
| @@ -76,12 +76,20 @@ class AP_AHRS_Backend | |||
|
|
|||
| // get the index of the current primary accelerometer sensor | |||
| virtual uint8_t get_primary_accel_index(void) const { | |||
| #if AP_INERTIALSENSOR_ENABLED | |||
There was a problem hiding this comment.
under what circumstances can we have AHRS without INS?
There was a problem hiding this comment.
ExternalAHRS is one example. Probably the only example by definition.
But I made these change because we're in the header file, and didn't wish to consider the implications of moving this implementation into the .cpp file in terms of flash and performance.
peterbarker
force-pushed
the
pr/random-ins-branch-cleanups
branch
4 times, most recently
from
d7b047c to
1ee7e09
Compare
peterbarker
force-pushed
the
pr/random-ins-branch-cleanups
branch
from
26b20d9 to
7fb7450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #24453 to make that one easier to reason about