AP_Scripting: add missing defines to build on Periph #25183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
previously requested changes
Oct 4, 2023
…andling of mission commands without AP_Mission
IamPete1
force-pushed
the
periph_scripting
branch
from
08276e8 to
09cde0c
Compare
|
Looks great but maybe we need a simple autotest to be sure we get a warning when a new binding breaks this again? |
tridge
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is sponsored by Spektreworks.
This adds defines such that scripting can run on periph with most everything else disabled, obviously we already run on vehicles with everything else enabled, I have not tested all possible combinations in between.
With everything else turned off the flash cost is around 100k but as you add back in more library's the extra bindings means the over head increases. Its only really practical with 512kB flash or more. To use you would have to enable romfs and embed the script into the firmware.
I have tested a "hello world" script on a CubeBlack periph heavy build.