Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Winch fix verbose user output when using pos control #25212

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Oct 9, 2023

This fixes a send-text message sent to the user when the winch is being retracted. Previously it would always say "lowering" but then provide a negative length. With this change it instead says "lowering" or "raising" and always displays an absolute length.

Below is a SITL test showing the fix.
winch-bad-message-before-vs-after

I've also done a couple of drive-by spelling corrections discovered while working on this PR.

@tridge tridge merged commit a477bf6 into ArduPilot:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants