Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane:reset in landing seq on mode change while disarmed #25260

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Hwurzburg
Copy link
Collaborator

@Hwurzburg Hwurzburg commented Oct 14, 2023

if you lose rc or accidentally change mode to rtl while disarmed on the ground with a DO_LAND_START setup you will prevented from arming when rc is restored or mode changed,if you dont have a gcs to reset the mission ...unless you power cycle

this will reset the mission to allow arming on non-autothrottle mode entry IF.....in landing sequence, disarmed, and not flying

tested in SITL

@Hwurzburg Hwurzburg requested a review from tridge October 14, 2023 00:52
@timtuxworth
Copy link
Contributor

I had a a similar problem after landing successfully earlier this year. Without a GCS I would be stuck and unable to arm. It would even survive a power off reboot. This might fix that too.

@IamPete1
Copy link
Member

This seems like quite a cryptic combination of things that will cause a mission reset. I wonder if people will hit this by mistake and be confused. We do have a mission reset aux switch.

@Hwurzburg
Copy link
Collaborator Author

Hwurzburg commented Oct 14, 2023

This was Tridges suggestion to avoid exactly that.... And most that have this problem don't know what to do about it

@IamPete1
Copy link
Member

Starting landing sequence in RTL is expected behavior. Yes its annoying in the case you describe, but the vehicle is behaving as expected and as it would in flight. This new reset is unexpected, it can happen when you switch between completely unrelated modes.

I see the argument that the vehicle is "stuck" in a state where you can't arm, but I think is a bit odd to magically fix it on mode change. Why not do the reset the first time the user tries to arm and hits the arming check?

@Hwurzburg
Copy link
Collaborator Author

that got me thinking...no need to rest the mission really...we dont do that on partial missions anyway #25263 as alternate

ArduPlane/mode.cpp Outdated Show resolved Hide resolved
ArduPlane/mode.cpp Outdated Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Oct 17, 2023

please add in a GCS send text for "In land sequence: mission restarted"

@Hwurzburg Hwurzburg force-pushed the landing_sequence_prearm branch from e61d332 to d2f054f Compare October 17, 2023 02:47
@Hwurzburg Hwurzburg requested a review from tridge October 17, 2023 14:57
@tridge tridge merged commit 410fbb9 into ArduPilot:master Oct 18, 2023
56 checks passed
@Hwurzburg
Copy link
Collaborator Author

thanks!

@Hwurzburg Hwurzburg deleted the landing_sequence_prearm branch October 18, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants