AP_DDS: Aggregate message #25329
Merged
AP_DDS: Aggregate message #25329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancyr
approved these changes
Oct 20, 2023
srmainwaring
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Changes LGTM. We'll be adding additional best effort streams, so I'm ok with consolidating the checks.
Ryanf55
approved these changes
Oct 23, 2023
|
Nice cleanup! Always nice to have PR's that reduce flash that still have readable code. Thanks for the contribution. |
peterbarker
reviewed
Oct 24, 2023
| output_reliable_stream = new uint8_t[DDS_BUFFER_SIZE]; | ||
| if (output_reliable_stream == nullptr) { | ||
| if (input_reliable_stream == nullptr || output_reliable_stream == nullptr) { |
There was a problem hiding this comment.
Perhaps we should be attempting to free memory here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some words are changed by flags.
I would consolidate the wording.