Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS: Change param default SRx_PARAMS to 50 #25365

Closed
wants to merge 6 commits into from

Conversation

magicrub
Copy link
Contributor

GCS: Change param default SRx_PARAMS to 50. If it's too fast it will self throttle down via buffer-size detection so no reason to artificially limit ourselves by default. Of note, some vehicles had this value set to 0 which would be treated as 10 later on in GCS_MAVLINK::set_ap_message_interval()

@Hwurzburg
Copy link
Collaborator

I am concerned that some rc systems will have issues with their telem link if they try to read params now...you assume eveything attached to MAVlink has variable buffers....I know of at least one LRS system (Dragonlink) that is very sensitive to stream rates

@IamPete1
Copy link
Member

I don't think this does anything for params over FTP, so I'm not really sure what the benifit is?

@WickedShell
Copy link
Contributor

I don't think this does anything for params over FTP, so I'm not really sure what the benifit is?

For those of us who are not using the FTP yet, it's very relevant. I do think 50 is probably too fast, but the bandwidth reservation logic currently means that you can almost always go to 20 and still use less bandwidth then the default. (At 57600 baud).

Making this a thing that HWDEF could override would be really nice though on initial connection.

@muramura
Copy link
Contributor

muramura commented Oct 25, 2023

Expects to send at the specified period.
If the cycle varies, it will be difficult to determine the status of the aircraft.
I use a radio, carrier network and know that bandwidth is not stable.
I am hoping that this instability will cause the transmission cycle to change NG.

You can set the transmission cycle in the LUA script.
I think you can use this as a reference to change the stream rate.

https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Scripting/examples/message_interval.lua

@peterbarker
Copy link
Contributor

A GCS could do this by sending in a SET_MESSAGE_INTERVAL as desired.

Or you could create a ROMFS file to set the interval on your vehicle (https://ardupilot.org/dev/docs/mavlink-requesting-data.html#specifying-message-rates-in-a-file).

Both of those options are less likely to completely stuff people on 433MHz no-flow-control radios :-)

@rmackay9
Copy link
Contributor

Like others I'm concerned about this change. I think we need to test that there is no effect for unused serial ports on Copter which current have all the serial rates set to zero by default.

@magicrub
Copy link
Contributor Author

DevCall result: best to solve this problem in GCS

@magicrub magicrub closed this Nov 20, 2023
@magicrub magicrub deleted the pr/param_50 branch November 20, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants