-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS: Change param default SRx_PARAMS to 50 #25365
Conversation
I am concerned that some rc systems will have issues with their telem link if they try to read params now...you assume eveything attached to MAVlink has variable buffers....I know of at least one LRS system (Dragonlink) that is very sensitive to stream rates |
I don't think this does anything for params over FTP, so I'm not really sure what the benifit is? |
For those of us who are not using the FTP yet, it's very relevant. I do think 50 is probably too fast, but the bandwidth reservation logic currently means that you can almost always go to 20 and still use less bandwidth then the default. (At 57600 baud). Making this a thing that HWDEF could override would be really nice though on initial connection. |
Expects to send at the specified period. You can set the transmission cycle in the LUA script. |
A GCS could do this by sending in a Or you could create a ROMFS file to set the interval on your vehicle (https://ardupilot.org/dev/docs/mavlink-requesting-data.html#specifying-message-rates-in-a-file). Both of those options are less likely to completely stuff people on 433MHz no-flow-control radios :-) |
Like others I'm concerned about this change. I think we need to test that there is no effect for unused serial ports on Copter which current have all the serial rates set to zero by default. |
DevCall result: best to solve this problem in GCS |
GCS: Change param default SRx_PARAMS to 50. If it's too fast it will self throttle down via buffer-size detection so no reason to artificially limit ourselves by default. Of note, some vehicles had this value set to 0 which would be treated as 10 later on in GCS_MAVLINK::set_ap_message_interval()