Fix C++ One Definition Rule violations and misc. UB #25394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Oct 29, 2023
tpwrules
force-pushed
the
fix-odr-violations
branch
from
0eceafc to
9a9bfd6
Compare
|
It should also be possible to use C++ |
|
GCC10 comes with the vagrant build. The build is still not passing even with these fixes because LTO isn't enabled. LTO can save size and increase performance by 10-20%. |
Ryanf55
approved these changes
Nov 14, 2023
peterbarker
reviewed
Nov 14, 2023
tridge
requested changes
Nov 15, 2023
Two structs with the same name must have exactly the same definition, no matter where they occur in the program. Move each sample register struct definition into the associated class definition so they are in a different namespace and no longer identicially named, thus fixing this issue.
Allows update of CAN interface during driver initialization without UB-inducing casting away of const.
Switch to const extern hal reference, then use mutability of can array to store the CAN driver reference during driver init and eliminate UB.
Eliminates UB, now possible with mutable can array in AP_HAL.
Eliminates UB, now possible with mutable can array in AP_HAL.
Avoids UB-inducing assumption that UART drivers are consecutive in the serial() function.
tpwrules
force-pushed
the
fix-odr-violations
branch
from
9a9bfd6 to
8e4070d
Compare
tpwrules
changed the title
|
Feedback is to split this up.
|
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various violations of the C++ One Definition Rule discovered during testing with LTO.
Fix a couple of easy UB cases noticed when doing the above.
Not necessarily an exhaustive list, but this does fix the complete list of violations diagnosed by GCC.
No code size or functional change.