hwdef: minimize_features on mini-pix, not minimize_fpv_osd #25400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'though, amusingly, I was actually using the ArduPilot fpv functionality on this board via DJI stuff. |
|
I thought we discussed this...since this is more a hobbyist target than a high end F407, the loss of CRSF telem would be avoided using fpv_osd rather than minimze_features |
|
It's supposed to be a pixhawk equivalent. It doesn't even have on-board OSD - I think minimize_features is probably more appropriate |
andyp1per
approved these changes
Oct 30, 2023
|
not passionate about this... |
Hwurzburg
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andy pointed out this was the wrong include in a recent PR, post-merge.