Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: gimbal_manager_set_pitchyaw is not a command #25458

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

olliw42
Copy link
Contributor

@olliw42 olliw42 commented Nov 4, 2023

This PR changes the name of the function handle_command_gimbal_manager_set_pitchyaw() to handle_gimbal_manager_set_pitchyaw(), since the underlying MAVLink message is not a command but a message.

The PR grabs the opportunity to also change one access of _mode to get_mode(). All other function in the AP_Mount library call get_mode(), except in this one place.

The PR also does two tiny formattings.

The PR is only cosmetic and nfc. Compiles and very lightly tested.

@olliw42
Copy link
Contributor Author

olliw42 commented Nov 4, 2023

oh, wau ... it seems to be extremely difficult for normal mortals to pass the checks. Any hint/help would be much appreciated.

@khancyr
Copy link
Contributor

khancyr commented Nov 4, 2023

Motor vibration test shouldn't related to the PR ... Unfortunately, we got some tests that aren't fully deterministic because of SITL or github action... So sometime we got random failure, specially on all fft things...

@olliw42
Copy link
Contributor Author

olliw42 commented Nov 4, 2023

many thx for your reponse. I too had a feeling that motor vib stuff shouldn't relate to the PR, but fact is it fails. Not sure I can do anything here, if so pl share. Let's see how this can move on.

@olliw42
Copy link
Contributor Author

olliw42 commented Nov 4, 2023

that's a cool reason for the checks to fail: #25445 (though here it's quite obvious what the gps fail is, not so the mot vib fail)
it's the same script as here. It's probably not unfair to say that the tests are a bit sensitive, and that it's not necessarily the submitted code.

@IamPete1 IamPete1 requested a review from rmackay9 November 5, 2023 14:57
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rmackay9 rmackay9 merged commit 4ffdb65 into ArduPilot:master Nov 5, 2023
86 checks passed
@olliw42 olliw42 deleted the owpr-handlegimbalmanager-tidy branch November 29, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants