Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcs method for checking connection to gcs #25468

Closed
wants to merge 2 commits into from
Closed

gcs method for checking connection to gcs #25468

wants to merge 2 commits into from

Conversation

alploskov
Copy link
Contributor

the is_connected method returns false if packets from the gcs did not arrive for 5 seconds and is return true when packets arrive more than once a second

used in custom version of dead reckoning script, tested on real hardware

@peterbarker
Copy link
Contributor

Why not do all of this calculation in the LUA? You've got access to the same data, and your constants (e.g. 5 seconds) aren't going to be suitable for others.

Note that this would also introduce another concept of "connected", which should already be covered by the vehicle being in GCS failsafe.

@alploskov
Copy link
Contributor Author

Thanks for feedback. You are right my solution is not suitable for all users.

@alploskov alploskov closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants