Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_RangeFinder: Add JRE-30 radar support #25495

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Nov 9, 2023

This adds support for the JAE-30 radar which is a 30m radar from Japan Aviation Electronics.

This replaces PR #25377 but I've made a few mostly small NFC tweaks including:

  1. shortened the DIST_MAX_CM definition from 50000cm to 5000cm (e.g. 50m). This is the max distance shown when out-of-range.
  2. removed an unused variable
  3. added some comments
  4. changed the crc loop to use uint32_t instead of "int"
  5. only enabled on boards with > 1MB of flash

I've tested this fairly thoroughly including confirming the status changes correctly including when the radar is pointed up into the sky where it sees nothing.

BTW, during the review of the previous PR we decided to re-work the state machine. The original author went ahead and did that and although it's still a little different from how we normally write these parsers I think it's close enough.

The corresponding wiki PR is here ArduPilot/ardupilot_wiki#5546

@rishabsingh3003
Copy link
Contributor

We usually have included a simulated rangefinder for all the recent serial rangefinders that were merged

@rmackay9 rmackay9 changed the title AP_RangeFinder: Add JRE-30-EM radar support AP_RangeFinder: Add JRE-30 radar support Nov 9, 2023
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Nov 13, 2023
@rmackay9
Copy link
Contributor Author

PR of JRE simulator: #25532

@rmackay9 rmackay9 force-pushed the jfbblue0922-JRE-lidar branch from 97e9777 to fac928f Compare November 14, 2023 11:24
@rmackay9 rmackay9 force-pushed the jfbblue0922-JRE-lidar branch from fac928f to 5039014 Compare November 14, 2023 23:59
@rmackay9 rmackay9 added WikiNeeded needs wiki update and removed WikiNeeded needs wiki update labels Nov 15, 2023
@rmackay9
Copy link
Contributor Author

I've re-tested and it all seems to work fine, thanks @peterbarker!

@rmackay9 rmackay9 merged commit da6f31d into ArduPilot:master Nov 15, 2023
@rmackay9 rmackay9 deleted the jfbblue0922-JRE-lidar branch November 15, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants