-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_RangeFinder: Add JRE-30 radar support #25495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We usually have included a simulated rangefinder for all the recent serial rangefinders that were merged |
PR of JRE simulator: #25532 |
97e9777
to
fac928f
Compare
rmackay9
commented
Nov 14, 2023
fac928f
to
5039014
Compare
I've re-tested and it all seems to work fine, thanks @peterbarker! |
tridge
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the JAE-30 radar which is a 30m radar from Japan Aviation Electronics.
This replaces PR #25377 but I've made a few mostly small NFC tweaks including:
I've tested this fairly thoroughly including confirming the status changes correctly including when the radar is pointed up into the sky where it sees nothing.
BTW, during the review of the previous PR we decided to re-work the state machine. The original author went ahead and did that and although it's still a little different from how we normally write these parsers I think it's close enough.
The corresponding wiki PR is here ArduPilot/ardupilot_wiki#5546