Add EFI Hirth simulator #25497
Closed
Add EFI Hirth simulator #25497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just sums the values of the bytes in a buffer and returns that sum modulus 256
Ryanf55
reviewed
Nov 9, 2023
|
|
||
| // sums the bytes in the supplied buffer, returns that sum mod 256 | ||
| // (i.e. shoved into a uint8_t) | ||
| uint8_t sum_of_bytes_in_buffer_mod_256(uint8_t *data, uint16_t count) |
There was a problem hiding this comment.
Ryanf55
reviewed
Nov 9, 2023
|
|
||
| void EFI_Hirth::update() | ||
| { | ||
| auto sitl = AP::sitl(); |
There was a problem hiding this comment.
Why not const auto *sitl = AP::sitl(); like below?
| status EFI_STATUS | ||
|
|
||
| ./Tools/autotest/autotest.py --gdb --debug build.Plane test.Plane.Hirth | ||
|
|
There was a problem hiding this comment.
Want to drop a link to the manufacturer's docs so one could cross-reference against the packet definitions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.... and fix the MegSquirt one a little