ProfiLED Fix #25518
Merged
ProfiLED Fix #25518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
force-pushed
the
pr-profil-fix
branch
from
bbe3534 to
3036564
Compare
IamPete1
reviewed
Nov 12, 2023
Use 64-bit timestamps for dshot send checks
andyp1per
force-pushed
the
pr-profil-fix
branch
from
3036564 to
dcc97ff
Compare
IamPete1
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
LGTM, Has been tested by @yuri-rage, https://discuss.ardupilot.org/t/profi-led-lua-script-not-working-since-4-2/108325/10
|
I tried to backport this to Copter-4.4 but hit a merge conflict. @andyp1per, if you're keen to get this in could you create a backport PR? |
|
With Andy's help this is included in Copter-4.4.4-beta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the signal match 4.1. Still does not work for me, but that may be down to my hardware setup.
Tested and working on the forums.