Use colcon test in CI to protect against AP_DDS regressions #25557
Conversation
Ryanf55
force-pushed
the
dds-enable-colcon-test-in-ci
branch
from
d98b89c to
3d13ba0
Compare
|
@khancyr Do you know why the ROS CI image doesn't have mavproxy in path? And, why it's not marked as an error or red in logs? |
|
CI image just have what is needed, so no mavproxy by default |
Ok. Should we make another CI image for doing this build, or should I extend the current ros image? Long term, I'd imagine as some point we'll expand to also test the gazebo + NAV2 headless in CI. |
Ryanf55
force-pushed
the
dds-enable-colcon-test-in-ci
branch
from
c2235cd to
83e084c
Compare
For now, we install mavproxy during the job instead of in docker. We'll find a faster solution long term with SITL. |
|
Rebase this once #25597 goes in |
Ryanf55
force-pushed
the
dds-enable-colcon-test-in-ci
branch
from
a9370d4 to
c9378f4
Compare
There was a problem hiding this comment.
LGTM thanks @Ryanf55. A note about the use of the networking flag would be helpful, but not required for this approval.
Ryanf55
force-pushed
the
dds-enable-colcon-test-in-ci
branch
from
c9378f4 to
cad20f3
Compare
* This flag was already removed, but the flags were left around Signed-off-by: Ryan Friedman <[email protected]>
* Use checkout v4 to pull in ArduPilot into a subdir first * Enable console cohesion during test since JUnit reporting is out of scope * Install mavproxy separately as needed, alternative to --console * Hide wget progress * Install local pymavlink Co-authored-by: Pierre Kancir <[email protected]> Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
dds-enable-colcon-test-in-ci
branch
from
cad20f3 to
b4cf189
Compare
This enables running our existing colcon tests in CI.
#25523 introduced a regression that would have been caught by
colcon test.I assumed
colcon testwas already running in CI.#25552 is a fix for the regression.
The purpose of this PR is to prevent further regressions that are caught by our existing DDS tests in CI by running a new job in CI.
Since the underlying networking code is expecting to evolve often, this will add additional testing, since AP_Networking has no automated testing yet.
Closes #25554
Depends on #25597