Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: Disarm after parachute release #25570

Closed
wants to merge 7 commits into from

Conversation

python36
Copy link
Contributor

Based on discussion of PR #25562.

Disarm after parachute release to avoid parachute tangling.

@khancyr khancyr added the Plane label Nov 20, 2023
@python36
Copy link
Contributor Author

@IamPete1 @khancyr please review this PR. If there are concerns, I can replace this with parametric functionality (CHUTE_THR_DISARM).

@timtuxworth
Copy link
Contributor

Just a thought - would it be better to do an emergency stop on the motors rather than a disarm?

@python36
Copy link
Contributor Author

@timtuxworth It doesn't matter to me how to do it. I want to avoid getting the parachute tangled. Now I’m solving it with custom firmware, which is not very good.

@python36
Copy link
Contributor Author

Hi. Maybe make a new bit in CHUTE_OPTIONS?
1 - disarme after releasing the parachute.

Please don't ignore me :) this is very important for me

@tridge
Copy link
Contributor

tridge commented Jan 30, 2024

@python36 I think we could consider moving the disarm into the AP_Parachute library so it is common code instead of being in each vehicle, and maybe add a CHUTE_OPTIONS bit to optionally disable the disarm?

@rmackay9
Copy link
Contributor

I'd even be happy without the option.. I think the vehicle should always disarm, the only question may be whether it should keep logging or not.. but I think we have an option for that already.

@python36
Copy link
Contributor Author

@tridge @rmackay9 thanks for the reply. I will create a new PR and then close this one. thank you

@python36
Copy link
Contributor Author

python36 commented Feb 2, 2024

Create new PR #26129 taking into account previous wishes.

@python36 python36 closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants